[gRPC] remote: add ability to specify array attributes in exported resources #1442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out the gRPC branch and noticed that certain attributes added to resources in my fork break when they are exported to the coordinator. The gRPC branch currently does not have support for array attributes.
This PR adds support for exactly that - (nested) array field attributes, by adding
MapValueArray
that contains repeatedMapValue
's to the.proto
definition file and the conversion between config dicts <-> grpc messages.I know the gRPC branch is still very much in movement, but I hope the PR will be considered. It improves the expandability of the framework in forks and closes the feature gap to the old crossbar implementation