Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's add a checkbox to select all items in the session list. #2318

Closed
agatha197 opened this issue Apr 7, 2024 · 0 comments · Fixed by #2519
Closed

Let's add a checkbox to select all items in the session list. #2318

agatha197 opened this issue Apr 7, 2024 · 0 comments · Fixed by #2519
Assignees
@ironAiken2
Labels
area:ux UI / UX issue. effort:normal Need to understand a few modules / some extent of contextual or historical information. field:UI / UX impact:visible This change is visible to users. platform:general type:enhance Add new features urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Milestone
24.03

Comments

@agatha197
Copy link
Contributor

Main idea

Currently, there is no select all checkbox, so each item has to be selected individually to terminate the session. Let's add a checkbox to select all items in the session list.

Alternative ideas

No response

Anything else?

No response
@agatha197 agatha197 added type:enhance Add new features effort:normal Need to understand a few modules / some extent of contextual or historical information. area:ux UI / UX issue. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. platform:general impact:visible This change is visible to users. field:UI / UX labels Apr 7, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 7, 2024
@ironAiken2 ironAiken2 self-assigned this Jul 5, 2024
@ironAiken2 ironAiken2 mentioned this issue Jul 5, 2024
Merged
6 tasks
agatha197 pushed a commit that referenced this issue Jul 29, 2024
@ironAiken2
feat: add a checkbox to select all items in session list (#2519)
a45dbad 
### This PR resolves [#2318](#2318) issue

### TL;DR

Add functionality to select multiple sessions using a header checkbox in the BackendAI session list.

### What changed?

- Introduced a new property `_boundHeaderCheckboxRenderer` to bind the header checkbox renderer function.
- Added a new property `sessionAllChecked` to track the state of the header checkbox.
- Implemented `_toggleSelectAll` method to handle the select/deselect all functionality.
- Added `headerCheckboxRenderer` method to render the header checkbox.

### How to test?

1. Navigate to the session list in the BackendAI application.
2. Verify the presence of a header checkbox in the session list table.
3. Click the header checkbox to select all sessions; click again to deselect.
4. Ensure the multi-action buttons are appropriately displayed based on selection.

### Why make this change?

This change enhances the session management capabilities by allowing users to quickly select and manage multiple sessions at once, improving usability and efficiency.

---

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ironAiken2 ironAiken2

Labels
area:ux UI / UX issue. effort:normal Need to understand a few modules / some extent of contextual or historical information. field:UI / UX impact:visible This change is visible to users. platform:general type:enhance Add new features urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
24.03
Development

Successfully merging a pull request may close this issue.

feat: add a checkbox to select all items in session list lablup/backend.ai-webui
2 participants
@agatha197 @ironAiken2