Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support per user image push #2300

Merged
merged 7 commits into from
Apr 4, 2024
Merged

feat: support per user image push #2300

merged 7 commits into from
Apr 4, 2024

Conversation

agatha197
Copy link
Contributor

core PR: lablup/backend.ai#1973

Descriptions

Commits ongoing session and pushes artifact to the designated registry.

How to test

Enable enableContainerCommit of the config.toml.

Screenshots

  • customized tag
image
  • On the last page, both original image name and tag are displayed so that the user can create a new session using the image name.
image
  • session list
image
  • commit session dialog
image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version: 24.03
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:enhance Add new features area:ux UI / UX issue. urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING urgency:5 It is imperative that action be taken right away. platform:general impact:visible This change is visible to users. field:UI / UX labels Apr 4, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 4, 2024
@agatha197 agatha197 self-assigned this Apr 4, 2024
@agatha197 agatha197 requested a review from lizable April 4, 2024 16:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
3.12% (-0.01% 🔻)
 117/3750
🔴 Branches
3.54% (-0.02% 🔻)
 87/2461
🔴 Functions
1.53% (-0% 🔻)
 19/1243
🔴 Lines
3.07% (-0.01% 🔻)
 113/3677

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from a1b0b55

kyujin-cho
kyujin-cho approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@kyujin-cho kyujin-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@agatha197 agatha197 merged commit ae50671 into main Apr 4, 2024
8 checks passed
@agatha197 agatha197 deleted the feature/per-user-image-push branch April 4, 2024 16:46
@agatha197 agatha197 mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@lizable lizable Awaiting requested review from lizable

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. field:localization field:UI / UX impact:visible This change is visible to users. platform:general size:L 100~500 LoC type:enhance Add new features urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @kyujin-cho