feature: Not connected alert banner in React #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
yomybaby
commented
Jun 25, 2024
|
|
||
| const { styles } = useStyles(); | ||
|
|
||
| const [softTimeout, setSoftTimeout] = useAtom(networkSoftTimeoutAtom); |
There was a problem hiding this comment.
FYI, softTimeot feature is handled by #2493 .
yomybaby
force-pushed
the
feature/no-network-banner
branch
from
5bb6d27
to
0923fcc
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.74% | 140/5107 |
| 🔴 | Branches | 2.96% | 101/3409 |
| 🔴 | Functions | 1.59% | 27/1696 |
| 🔴 | Lines | 2.61% | 131/5010 |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from db62f9a
ironAiken2
requested changes
Jun 26, 2024
yomybaby
force-pushed
the
feature/no-network-banner
branch
from
0923fcc
to
e7b5dbf
Compare
6 tasks
|
@ironAiken2 I created a new stack to improve notifications. Please check that #2502 PR and resolve a current PR. |
Merge activity
|
### TL;DR Added a network status banner to the main layout component. | before | after | | -- | -- | |  |  | ### What changed? - Introduced `NetworkStatusBanner` component. - Displays when the user is offline - Updated translations for the offline message in multiple languages. - Removed old snackbar-based offline indicator. ### How to test? 1. Go offline and verify that the new banner appears with the appropriate message. ### Why make this change? Enhances user experience by providing clearer visual feedback on network status directly within the main layout. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
ironAiken2
force-pushed
the
feature/no-network-banner
branch
from
e7b5dbf
to
db62f9a
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a network status banner to the main layout component.
What changed?
NetworkStatusBannercomponent.How to test?
Why make this change?
Enhances user experience by providing clearer visual feedback on network status directly within the main layout.
Checklist: (if applicable)