Fix: Resource Number displays an infinity symbol unexpectedly #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.37% | 329/6121 |
| 🔴 | Branches | 5.02% | 211/4202 |
| 🔴 | Functions | 3.08% | 62/2013 |
| 🔴 | Lines | 5.27% | 315/5977 |
Test suite run success
83 tests passing in 9 suites.
Report generated by 🧪jest coverage report action from 471c556
Merge activity
|
### TL;DR After #2615, the Resource Number displays an infinity symbol unexpectedly.  This PR fixes that bug and refactors the code related to the `max` display.
agatha197
force-pushed
the
fix/resource-number-has-inifity-always
branch
from
1d7a183
to
471c556
Compare
yomybaby
added a commit
that referenced
this pull request
Sep 3, 2024
### TL;DR After #2615, the Resource Number displays an infinity symbol unexpectedly.  This PR fixes that bug and refactors the code related to the `max` display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
After #2615, the Resource Number displays an infinity symbol unexpectedly.
This PR fixes that bug and refactors the code related to the
maxdisplay.