-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: provide deprecation msg to max_vfolder_size
graphene field
#1644
Conversation
Currently, |
I didn't check those parts. I updated the code, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As #1643 is merged, please update the merge conflict. (max_vfolder_count
's GQL type is changed from BigInt
to grpahene.Int
)
Thank you, I resolved the part and pushed new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-line news fragment will break the formatting when auto-generating changelogs. Please put them in a single line, and contract as one sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GraphQL schema has changed as expected.
type ProjectResourcePolicy {
id: ID!
name: String!
created_at: DateTime!
max_vfolder_count: BigInt
max_vfolder_size: BigInt @deprecated(reason: "Deprecated since 23.09.1")
max_quota_scope_size: BigInt
}
follow up
#1397
#1643
max_vfolder_size
field.max_quota_scope_size
.Checklist: (if applicable)