-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore removed graphene fields and set them deprecated #1677
Conversation
return val | ||
|
||
|
||
def deprecation_reason_msg(version: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the detail: str
to here alos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for this, everything looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it, thank you!
Backported-from: main Backported-to: 23.09
Deprecated graphql fields should not be removed.
The fields to be deleted should be marked with a deprecation message and deleted after a specified support period.
Checklist: (if applicable)