fix: restore removed graphene fields and set them deprecated #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
yomybaby
requested changes
Nov 1, 2023
| return val | ||
|
|
||
|
|
||
| def deprecation_reason_msg(version: str): |
There was a problem hiding this comment.
Let's add the detail: strto here alos.
There was a problem hiding this comment.
Except for this, everything looks good to me.
fregataa
changed the title
fregataa
changed the title
achimnol
pushed a commit
that referenced
this pull request
Nov 6, 2023
Backported-from: main Backported-to: 23.09
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated graphql fields should not be removed.
The fields to be deleted should be marked with a deprecation message and deleted after a specified support period.
Checklist: (if applicable)