Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix docs typos #1102

Merged
merged 5 commits into from
May 6, 2023
Merged

doc: fix docs typos #1102

merged 5 commits into from
May 6, 2023

Conversation

hai-x
Copy link
Contributor

@hai-x hai-x commented Apr 28, 2023

1.修复文档repo本地开发因 node 版本过低导致 vitepress 底层使用 node:xxx 模块报错。
2.修复文档暗黑模式下顶部搜索按钮背景色样式问题。
3.修复文档中标点符号等问题。

@cla-assistant
Copy link

cla-assistant bot commented Apr 28, 2023

CLA assistant check
All committers have signed the CLA.

@hai-x hai-x changed the title Fix docs typos docs: fix docs typos Apr 28, 2023
maslow
maslow previously approved these changes Apr 29, 2023
@labring labring deleted a comment from cla-assistant bot Apr 29, 2023
@hai-x
Copy link
Contributor Author

hai-x commented Apr 29, 2023

i just have resolved the conflict between this branch and main branch, please review again. @maslow

@maslow maslow requested a review from nightwhite April 30, 2023 08:53
@nightwhite nightwhite changed the title docs: fix docs typos doc: fix docs typos Apr 30, 2023
Copy link
Collaborator

@nightwhite nightwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem

@hai-x
Copy link
Contributor Author

hai-x commented May 4, 2023

no problem

I directly limit the judgment condition instead of using semver to judge node version. Because semver is not installed when developer first install dependencies. It cause git action failed.

@maslow maslow requested a review from nightwhite May 6, 2023 03:08
@maslow maslow merged commit f108bc7 into labring:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants