Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): upgrade minio version to fix CVE-2023-28432 #960

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

maslow
Copy link
Member

@maslow maslow commented Mar 24, 2023

@@ -18,7 +18,7 @@ clusterDomain: cluster.local
##
image:
repository: quay.io/minio/minio
tag: RELEASE.2023-02-27T18-10-45Z
tag: RELEASE.2023-03-22T06-36-24Z
pullPolicy: IfNotPresent

imagePullSecrets: []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a code review for the patch.

The patch changes the tag of the image from RELEASE.2023-02-27T18-10-45Z to RELEASE.2023-03-22T06-36-24Z. This seems to be an update to a newer version of the image.

From a security perspective, this is a good change to make as it ensures that all components are up-to-date and no known vulnerabilities will exist in the code.

From a bug risk perspective, this change should not have any negative impact. The process of updating to a newer version of the image should be tested before deploying to production.

From an improvement perspective, I would suggest adding version control to the codebase (such as git). This will give you better control over the code and make it easier to track changes. Additionally, it will also provide a backup in case something goes wrong.

@maslow maslow merged commit b38c288 into labring:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant