fix(server): fix instance task error #988
Conversation
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -130,7 +130,7 @@ export class InstanceTaskService { | |||
| const instance = await this.instanceService.get(app) | |||
| const available = isConditionTrue( | |||
| 'Available', | |||
| instance.deployment.status?.conditions, | |||
| instance.deployment?.status?.conditions || [], | |||
| ) | |||
| if (!available) { | |||
| await this.relock(appid, waitingTime) | |||
There was a problem hiding this comment.
:
The code patch looks good, and it appears the intent is to check if the deployment status condition is true. It looks like the code is trying to access the instance object and check the deployment status condition.
However, there is a bug risk because the instance object might be null. To prevent this, the code should add a check for null before attempting to access the instance object. Additionally, the code should check if the instance.deployment object is also not null before accessing the status conditions.
The code patch can be improved by adding more defensive programming. For example, the code can check for any edge cases that could lead to an error and handle those cases gracefully. The code should also include more comments to explain what it is doing and why.
No description provided.