Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add check containerd #4748

Merged
merged 1 commit into from
May 23, 2024
Merged

fix:add check containerd #4748

merged 1 commit into from
May 23, 2024

Conversation

ghostloda
Copy link
Collaborator

Check whether the containerd is installed. fix #4738

Copy link

sweep-ai bot commented May 21, 2024

Sweep: PR Review

pkg/checker/host_checker.go

The changes introduce a new validation step in the Check method to ensure that containerd is not installed on any of the specified IPs.

Sweep Found These Issues

  • The checkContainerd function returns an error if containerd is installed on any IP, but it does not handle the case where the command fails for reasons other than containerd not being installed, potentially masking other issues.
  • func checkContainerd(s exec.Interface, ipList []string) error {
    logger.Info("checker:containerd %v", ipList)
    for _, ip := range ipList {
    _, err := s.CmdToString(ip, "containerd --version", "")
    if err == nil {
    return fmt.Errorf("containerd is installed on %s please uninstall it first", ip)
    }
    }
    return nil

    View Diff


@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented May 21, 2024

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1250
✅ Successful 378
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 871
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@ghostloda ghostloda requested a review from cuisongliu May 22, 2024 07:32
@bxy4543 bxy4543 added the need-e2e-apply-test need-e2e-apply-test label May 23, 2024
@sealos-ci-robot
Copy link
Member

🤖 says: E2E k8s multi node ARM64 Test Result: ‼️ Failure , E2E k8s multi node AMD64 Test Result: ‼️ Failure
See: https://github.com/labring/sealos/actions/runs/9201147949

@sealos-ci-robot
Copy link
Member

🤖 says: E2E k3s multi node ARM64 Test Result: ‼️ Failure , E2E k3s multi node AMD64 Apply Test Result: ‼️ Failure
See: https://github.com/labring/sealos/actions/runs/9201147948

@bxy4543
Copy link
Member

bxy4543 commented May 23, 2024

🤖 says: E2E k3s multi node ARM64 Test Result: ‼️ Failure , E2E k3s multi node AMD64 Apply Test Result: ‼️ FailureSee: https://github.com/labring/sealos/actions/runs/9201147948

This is just a problem with the testing interface, I will fix it later.

@cuisongliu cuisongliu merged commit 18be6fe into labring:main May 23, 2024
118 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: failed to init masters: generate init config error: exit status 1
4 participants