Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govulncheck to CI and bump dependencies #2362

merged 1 commit into from Dec 14, 2022


Copy link

@aldas aldas commented Dec 13, 2022

Add to CI flow and bump dependencies

I had to refactor CI flow to 2 parts as govulncheck reports problem for older Go versions thus causing workflow to fail. Therefore run static analysis only with latest Go version. There is no point to run golint and staticcheck with older versions as they are almost always teemed to fail (because of vulns that have patched in later versions).

I added env.LATEST_GO_VERSION so it is easier in future to change Go version for step where are using it"single" version of GO.

Copy link
Contributor Author

aldas commented Dec 13, 2022

@lammel please review

Copy link

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see govulncheck for echo. Should help when releasing.
Let's see how many vuln warnings we get.

@lammel lammel merged commit abecadc into labstack:master Dec 14, 2022
@aldas aldas mentioned this pull request Dec 27, 2022
@aldas aldas deleted the add_govulncheck_2_ci branch December 29, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants