Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Cleanup code #16

Merged
merged 3 commits into from
Feb 23, 2018
Merged

[FIX] Cleanup code #16

merged 3 commits into from
Feb 23, 2018

Conversation

im-kulikov
Copy link
Contributor

  • cleanup code
  • fix bytes package

@im-kulikov
[FIX] Cleanup code
bda4cec 
- cleanup code
- fix bytes package
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 68.07% when pulling bda4cec on im-kulikov:cleanup-code into 57409ad on labstack:master.

@coveralls
Copy link

coveralls commented Feb 10, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.2%) to 69.527% when pulling 402af04 on im-kulikov:cleanup-code into 57409ad on labstack:master.

@im-kulikov
Copy link
Contributor Author

@vishr any updates?

@im-kulikov
Copy link
Contributor Author

@vishr any updates before merge?

@im-kulikov
Copy link
Contributor Author

@vishr any updates?

1 similar comment
@im-kulikov
Copy link
Contributor Author

@vishr any updates?

@vishr
Copy link
Member

vishr commented Feb 23, 2018

@im-kulikov today for sure ;).

@im-kulikov
Copy link
Contributor Author

@vishr good news 🙂

@vishr
Copy link
Member

vishr commented Feb 23, 2018 •
edited
Loading

@im-kulikov Till then you can look into open issues ;)

@im-kulikov
Copy link
Contributor Author

Yep, no problem 🙂

@im-kulikov im-kulikov mentioned this pull request Feb 23, 2018
Closed
@im-kulikov
Copy link
Contributor Author

im-kulikov commented Feb 23, 2018 •
edited
Loading

@vishr as I see..

@vishr vishr merged commit 058e16e into labstack:master Feb 23, 2018
@vishr
Copy link
Member

vishr commented Feb 23, 2018

@im-kulikov thanks for your contribution 🎉

@im-kulikov im-kulikov deleted the cleanup-code branch February 24, 2018 07:01
@im-kulikov
Copy link
Contributor Author

@vishr, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishr vishr vishr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im-kulikov @coveralls @vishr