Linting and typing fixes

The main change is that I've had to add a
decorator to keep mypy happy when we
add attributes to functions.  This is a known
issue:
python/mypy#2087

Author: rwb27

src/labthings/apispec/plugins.py

@@ -54,6 +54,7 @@ class MarshmallowPlugin(_MarshmallowPlugin):
 
 class FlaskLabThingsPlugin(BasePlugin):
     """APIspec plugin for Flask LabThings"""
+
     spec = None
 
     def init_spec(self, spec):

src/labthings/default_views/actions.py

@@ -4,12 +4,13 @@
 from ..find import current_labthing
 from ..marshalling import use_args
 from ..schema import ActionSchema
-from ..views import View
+from ..views import View, described_operation
 
 
 class ActionQueueView(View):
     """List of all actions from the session"""
 
+    @described_operation
     def get(self):
         """Action queue
 
@@ -49,6 +50,7 @@ class ActionObjectView(View):
 
     parameters = [TASK_ID_PARAMETER]
 
+    @described_operation
     def get(self, task_id):
         """Show the status of an Action
 
@@ -73,6 +75,7 @@ def get(self, task_id):
         "404": {"description": "Action not found"},
     }
 
+    @described_operation
     @use_args({"timeout": fields.Int()})
     def delete(self, args, task_id):
         """Cancel a running Action

src/labthings/default_views/extensions.py

@@ -1,14 +1,15 @@
 """Top-level representation of attached and enabled Extensions"""
 from ..find import registered_extensions
 from ..schema import ExtensionSchema
-from ..views import View
+from ..views import View, described_operation
 
 
 class ExtensionList(View):
     """List and basic documentation for all enabled Extensions"""
 
     tags = ["extensions"]
 
+    @described_operation
     def get(self):
         """List enabled extensions.
 

src/labthings/default_views/root.py

@@ -1,10 +1,11 @@
 from ..find import current_labthing
-from ..views import View
+from ..views import View, described_operation
 
 
 class RootView(View):
     """W3C Thing Description"""
 
+    @described_operation
     def get(self):
         """Thing Description
         ---

src/labthings/schema.py

@@ -172,19 +172,17 @@ def build_action_schema(
     if not name.endswith("Action"):
         name = f"{name}Action"
 
-    class GenSchema(base_class):
-        pass
+    class_attrs: Dict[str, Union[fields.Nested, fields.Field, str]] = {}
 
-    GenSchema.__name__ = name
-    GenSchema.__doc__ = (
-        f"Description of an action, with specific parameters for `{name}`"
-    )
+    class_attrs[
+        "__doc__"
+    ] = f"Description of an action, with specific parameters for `{name}`"
     if input_schema:
-        GenSchema.input = nest_if_needed(input_schema)
+        class_attrs["input"] = nest_if_needed(input_schema)
     if output_schema:
-        GenSchema.output = nest_if_needed(output_schema)
+        class_attrs["output"] = nest_if_needed(output_schema)
 
-    return GenSchema
+    return type(name, (base_class,), class_attrs)
 
 
 def openapi_array(schema: FuzzySchemaType) -> Dict:

src/labthings/views/__init__.py

@@ -1,6 +1,7 @@
 import datetime
 from collections import OrderedDict
-from typing import Dict, List, Optional, Set
+from typing import Callable, Dict, List, Optional, Set, cast
+from typing_extensions import Protocol
 
 from flask import request
 from flask.views import MethodView
@@ -25,6 +26,18 @@
 OptionalSchema = Optional[FuzzySchemaType]
 
 
+class DescribedOperation(Protocol):
+    summary: str
+    description: str
+    parameters: List
+    responses: Dict
+
+
+def described_operation(func: Callable) -> DescribedOperation:
+    """Add type information so mypy permits us to use attributes"""
+    return cast(DescribedOperation, func)
+
+
 class View(MethodView):
     """A LabThing Resource class should make use of functions
     get(), put(), post(), and delete(), corresponding to HTTP methods.
@@ -168,6 +181,7 @@ def __init_subclass__(cls):
         """
         cls._deque = Deque()  # Action queue
 
+    @described_operation
     @classmethod
     def get(cls):
         """
@@ -285,6 +299,7 @@ class EventView(View):
     _cls_tags = {"events"}
     _deque = Deque()  # Action queue
 
+    @described_operation
     @classmethod
     def get(cls):
         """

src/labthings/views/builder.py

@@ -4,7 +4,7 @@
 from typing import Type
 
 from flask import abort, send_file
-from . import View
+from . import View, described_operation
 
 
 def static_from(static_folder: str, name=None) -> Type[View]:
@@ -19,6 +19,7 @@ def static_from(static_folder: str, name=None) -> Type[View]:
         name = f"static-{uid}"
 
     # Create inner functions
+    @described_operation
     def _get(_, path=""):
         """
         :param path:  (Default value = "")