Icon refactoring4 #1339
Merged
Icon refactoring4 #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some themes don't have hover variants for button pixmaps. It looks better visually to use the non-hover variants as fallbacks rather than the built-in 6x6 pixmaps.
johanmalm
force-pushed
the
icon-refactoring4
branch
from
b4479e1
to
b3a6b43
Compare
|
Ready for review. I think this should be enough button hacking for |
Consolatis
reviewed
Dec 18, 2023
Consolatis
reviewed
Dec 18, 2023
Consolatis
reviewed
Dec 18, 2023
Consolatis
reviewed
Dec 18, 2023
Consolatis
reviewed
Dec 18, 2023
|
All review comments have been addressed. |
johanmalm
force-pushed
the
icon-refactoring4
branch
from
dbb1273
to
3e4f2ea
Compare
|
Couldn't contain myself... have done the fixup onto the middle commit. |
Consolatis
reviewed
Dec 20, 2023
...by copying the non-hover variant and adding a transparent overlay. Co-authored-by: @johanmalm
...and simplify button_xbm_load() by splitting it into one function that loads an xbm file and another that creates an icon from a builtin bitmap.
johanmalm
force-pushed
the
icon-refactoring4
branch
from
3e4f2ea
to
cfd3846
Compare
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_hovericons_hoverbuttons with an xbm/svg/png, just copy the non-hover variant and add an overlaybutton_xbm_load()by moving some of the fallback logic totheme.c