Update to Besu 23.4.4 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump SLF4J version and replace helper for lambdas Signed-off-by: Diego López León <dieguitoll@gmail.com> * Remove unnecessary toString calls Signed-off-by: Diego López León <dieguitoll@gmail.com> * Replace unnecessaryy lambdas for constant references Signed-off-by: Diego López León <dieguitoll@gmail.com> --------- Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Added Ethereum execution spec test to be generated and executed by reference tests gradle task. Add `https://github.com/ethereum/execution-spec-tests/releases` as custom ivy repository to easily download and cache the test specs. Updated the reference test gradle file to generate the test Java classes. Signed-off-by: Usman Saleem <usman@usmans.info>
…suAsProcess = false (hyperledger#5145) Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Jason Frame <jason.frame@consensys.net>
…yperledger#5146) Add an acceptance test to ensure eth_getBlockByNumber and eth_getBlockByHash return withdrawals correctly for shanghai Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ger#5151) Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
* update changelog in main to reflect current releases * include PR link for goerli shapella Signed-off-by: garyschulte <garyschulte@gmail.com>
* fixing the sonarcloud building in gha * update to temurin 17 * adds checksums on sonarqube plugins * ignore generated for spdx * runs at midnight Tuesday mornings UTC --------- Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Joshua Fernandes <joshua.fernandes@consensys.net>
* copy layered worldstate fix for eth_call Signed-off-by: garyschulte <garyschulte@gmail.com>
* Fix empty body concept after shanghai Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Check protocolSchedule to create empty block and add withdrawals to empty block check Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Extract block creation into a private method Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Nit changes Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Refactor test names Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Support --state.reward=-1, which means no block reward handling. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
…hyperledger#5170) Signed-off-by: Jason Frame <jason.frame@consensys.net>
Assert on objects but use prettyString for failure message Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Pull up and simplify data passed to CheckpointSource, which then allows checkpointBlockHeader to be used by protocolSchedule.getByBlockHeader. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…r#5171) Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Reduce the number of places that expose Log4J classes as a part of the interfaces for methods and classes. While Log4j remains the default we still need to be able to function when the Log4J jars are removed from the classpath. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
When receiving transactions from a file parse them as an RLP list. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Antoine Toulme <antoine@toulme.name>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* Remove deprecated EF bootnodes Signed-off-by: Rafael Matias <rafael@skyle.net> * Remove unnecessary bootnode data from checkpoint json test * Remove ef deprecated bootnodes from genesis Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Rafael Matias <rafael@skyle.net> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Completes the implementation of EIP-6110 * Decode and extract deposit from transaction receipt log * Introduce depositContractAddress field in genesis file * Validate deposits in a block against the transaction receipt logs * Update engine_newPayloadV2 and engine_getPayloadV2 according to the spec. Some of the non-functional components were partially implemented in the previous PR Signed-off-by: naviechan <naviechan@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* Extract method Signed-off-by: Diego López León <dieguitoll@gmail.com> * Extract tracer closing outside of try-with-resources Signed-off-by: Diego López León <dieguitoll@gmail.com> * Add t8n server Signed-off-by: Diego López León <dieguitoll@gmail.com> --------- Signed-off-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com>
* junit5 * lenience Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* junit5 Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Faster MCOPY implementation wire in deep call to System.arrayCopy instead of buffer copy. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
* Add debug_getRawTransaction Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add changelog entry Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
* Add lock to creation of pending transaction stream Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Alternative synchonization of signalInvalidAndRemoveDependentTransactions Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Matthew Whitehead <matthew1001@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…ge (hyperledger#5637) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Updates needed to keep executing execution-spec-tests * add withdrawals support * add access lists to transactions * accept t8n and b11r CLI args that are zero length or all whitespace * Enumerate forks in t8n and b11r help * remove JSON wrapping from t8n transaction RLP Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
BLS12 signatures were speculatively added in cancun in late 2022. This is no longer accurate. Move the implementation to the "Future_EIPs" fork so that it will remain testable and not accidentally get included accidentally. Also add missing fluent APIs. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
* add new class to reflection config * move CLI output to be system-err oriented * make logger in evmtool nop * exclude some problematic jars from compilation - mixed versions of bouncy castle - netty initializations of log4j * Standardize JSON ObjectMapper Construction * Add some manual mappings * Directly instantiate crypto algorithms where appropriate Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* only update peer with the first and last block Signed-off-by: Stefan <stefan.pingel@consensys.net>
…ledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
diega
requested changes
Jul 6, 2023
config/src/main/java/org/hyperledger/besu/config/JsonGenesisConfigOptions.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/hyperledger/besu/config/JsonGenesisConfigOptions.java
Show resolved
Hide resolved
config/src/main/java/org/hyperledger/besu/config/StubGenesisConfigOptions.java
Outdated
Show resolved
Hide resolved
datatypes/src/main/java/org/hyperledger/besu/datatypes/Address.java
Outdated
Show resolved
Hide resolved
eum602
force-pushed
the
falcon_precompiled_updates
branch
from
02a93f4
to
71c7dc3
Compare
|
Allright @diega all comments were addressed |
eum602
pushed a commit
that referenced
this pull request
Nov 3, 2023
…perledger#5182) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description There is an issue when restarting Besu when a backward sync session is running, since after the restart it is possible that the Consensus client sends a FcU or a NewPayload for a block that is present in the backward sync storage, but not yet imported, so not on the main chain, but still the backward sync thinks it should not do anything with that block, so it returns like it has completed the sync, but since the sync is not done actually then the internal error that the finalize block is not present. The solution is to persist the backward sync status, so in case of a restart, it can resume from where it was interrupted. ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> fixes hyperledger#5053 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
that referenced
this pull request
Nov 3, 2023
…rledger#5221) <!-- Thanks for sending a pull request! Please check out our contribution guidelines: --> <!-- https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md --> ## PR description This PR aims to remove the usage of getByBlockNumber from the FlexiblePrivacyPrecompiledContract. As far as analysis shows the only requirement is to get a protocolSpec (it doesn't matter which one) currently it always fetches the protocolSpec for block number 1 which can vary according to the network config. We're changing that get the protocolSpec for block 0 which is the only block we always have the header. AT nonmainnet on circle CI Pipeline - 21048 ## Fixed Issue(s) <!-- Please link to fixed issue(s) here using format: fixes #<issue number> --> <!-- Example: "fixes #2" --> Fixes hyperledger#5160 ## Documentation - [x] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation). ## Acceptance Tests (Non Mainnet) - [x] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules. ## Changelog - [x] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog). --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update Falcon Precompiled Feature code (The code is using liboqs and the initial expected functionalities were untoched)
Fixed Issue(s)
Changelog