Adapt implementation from lace #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbeard4 Any thoughts on how to handle code coverage for this? I've removed some dead code though there are a handful of uncovered lines yet. We could add coverage ignores and open an issue, or else maybe it's worth my taking maybe half an hour to find a few more examples that exercise the whole codebase. |
|
I like the approach of adding pragmas to skip coverage so that you are unblocked, and creating issues to add tests for these lines so that they do not get lost. I went ahead and added these pragmas in 1162bfe. I will create github issues now. |
|
I created a github issue for this: #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor / rewrite of the mesh–plane intersection code in Lace:
https://github.com/lace/lace/blob/a19d14eeca37a66af442c5a73c3934987d2d7d9a/lace/intersection.py
https://github.com/lace/lace/blob/a19d14eeca37a66af442c5a73c3934987d2d7d9a/lace/test_intersection.py
I've filled in a couple gaps in test coverage, though there are still a few more.
The docs are getting built on Netlify.