Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add line length as a check in make lint #941

Closed
nschmeller opened this issue Oct 12, 2022 · 1 comment · Fixed by #1123
Closed

feat: add line length as a check in make lint #941

nschmeller opened this issue Oct 12, 2022 · 1 comment · Fixed by #1123
Assignees
@nschmeller
Labels
feat New feature or request

Comments

@nschmeller
Copy link
Contributor

Feature Request

Describe the Feature Request
We'd prefer to have line lengths that are reasonable (say 100chars). We should include this in make lint

Describe Preferred Solution
I think golangci-lint has this feature, using a tool called LLL

Additional Context
Inspired by this discussion: #934 (comment)
@nschmeller nschmeller added the feat New feature or request label Oct 12, 2022
@afiune
Copy link
Contributor

afiune commented Oct 12, 2022

tenor-185495839

afiune added a commit that referenced this issue Jan 19, 2023
@afiune
style(lint): enable line length check
b5869f3 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this issue Jan 19, 2023
Merged
afiune added a commit that referenced this issue Jul 1, 2023
@afiune
style(lint): enable line length check
510bf66 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Jul 1, 2023
@afiune
style(lint): enable line length check
9beea73 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Jul 2, 2023
@afiune
style(lint): enable line length check
da2ed20 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Jul 3, 2023
@afiune
style(lint): enable line length check
0a4f558 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Jul 3, 2023
@afiune
style(lint): enable line length check
de2bdc4 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit that referenced this issue Jul 3, 2023
@afiune
style(lint): enable line length check (#1123)
f73932f 
Closes #941

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this issue Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nschmeller nschmeller

Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(lint): enable line length check lacework/go-sdk
2 participants
@afiune @nschmeller