feat: prosast component data upload #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemanthgk10
reviewed
Jun 7, 2024
| @@ -70,6 +71,10 @@ func (svc *ComponentDataService) UploadSastTables( | |||
| return svc.doUploadFiles(name, []string{"sast"}, paths, URL_TYPE_SAST_TABLES) | |||
| } | |||
|
|
|||
| func (svc *ComponentDataService) UploadProSast(name string, paths []string) (string, error) { | |||
| return svc.doUploadFiles(name, []string{"sast"}, paths, URL_TYPE_PROSAST) | |||
There was a problem hiding this comment.
Sounds like you are using the same tag as the other one. Will it not have any impact?
func (svc *ComponentDataService) UploadSastTables(
name string, paths []string) (string, error) {
return svc.doUploadFiles(name, []string{"sast"}, paths, URL_TYPE_SAST_TABLES)
}
Do you need a separate tag?
There was a problem hiding this comment.
Thanks for reviewing this @hemanthgk10. It is strange that there are 2 'type' fields - legacy code.
The tags are used here to distinguish between SCA/IAC and SAST RedPanda topics.
The UrlType is used here to select a S3 key prefix.
I hope you can see from this PR that if I want to choose a different S3 key prefix I need to use the UrlType. The sast tag doesn't need to change.
ipcrm
approved these changes
Jun 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ProSAST must upload with the
UrlTypeofProSast.Improved resourceGroup integration test by telling user how to recover.
How did you test this change?
Unit test
Issue
https://lacework.atlassian.net/browse/COD-3355