feat: add configure command #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
Adding a new `configure` command to set up the Lacework CLI: ``` $ lacework configure ✔ Account: example ✔ Access Key ID: EXAMPLE_12FBEB06B01249B634D2129655B8652D0EBC2DD141B1234 ✔ Secret Access Key: _186bb1dcbde222d77ccbbb25c516al09 You are all set! ``` Closes #35 Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
ghost
force-pushed
the
afiune/cmd/configure
branch
from
598aca9
to
87a8d0a
Compare
scottford-lw
approved these changes
Apr 11, 2020
There was a problem hiding this comment.
@afiunelw This is a great feature. I was able to build the latest version and test with multiple configurations. I guess the only thing would be to add an update the cli README, but I am guessing you are already tracking that.
https://github.com/lacework/go-sdk/tree/afiune/cmd/configure/cli#configuration-file
I am happy to update the docs after you merge as well
|
If you could help me documenting it, that would be great. 💯 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new
configurecommand to set up the Lacework CLI:Closes #35
Jira: ALLY-38
Signed-off-by: Salim Afiune Maya afiune@lacework.net