Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

Support for Handlebars.js #63

Closed
heymichaelp opened this issue Feb 28, 2014 · 8 comments
Closed

Support for Handlebars.js #63

heymichaelp opened this issue Feb 28, 2014 · 8 comments

Comments

@heymichaelp
Copy link

I'm wondering what the recommended method of integration into handlebars.js is. The examples outlined in the README.md only outline implementations in Jade and EJS, but my site uses Handlebars templates. I see that on this line: https://github.com/niftylettuce/express-cdn/blob/master/lib/main.js#L514, you reference only two valid extensions - does this mean there isn't support for any templating language other than these two? If so, this should be made explicit in the README.md

@niftylettuce
Copy link
Collaborator

Pull requests are more than welcome, the documentation only shows examples
for EJS and Jade, that is kind of obvious it's only for EJS and Jade... but
I'd really like to see Handlebars integrated as I know others probably
could benefit from it. Thank you.

On Fri, Feb 28, 2014 at 4:01 PM, Michael Phillips
notifications@github.comwrote:

I'm wondering what the recommended method of integration into
handlebars.js http://handlebarsjs.com/ is. The examples outlined in the
README.md only outline implementations in Jade and EJS, but my site uses
Handlebars templates. I see that on this line:
https://github.com/niftylettuce/express-cdn/blob/master/lib/main.js#L514,
you reference only two valid extensions - does this mean there isn't
support for any templating language other than these two? If so, this
should be made explicit in the README.md

Reply to this email directly or view it on GitHubhttps://github.com//issues/63
.

@niftylettuce
Copy link
Collaborator

I see you started working on this already, can't wait to accept your PR, thanks @createbang!

@heymichaelp
Copy link
Author

I'm not sure I agree that the presence of two examples means that those are the only two ways something can work. Anyway, I do have a PR in the works for this, with an updated README.md to include compatible templating languages.

@niftylettuce
Copy link
Collaborator

perfect

On Sat, Mar 1, 2014 at 10:57 AM, Michael Phillips
notifications@github.comwrote:

I'm not sure I agree that the presence of two examples means that those
are the only two ways something can work. Anyway, I do have a PR in the
works for this, with an updated README.md to include compatible
templating languages.

Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-36428168
.

@niftylettuce
Copy link
Collaborator

@createbang hows the PR?

@heymichaelp
Copy link
Author

@niftylettuce it's basically done, but I want to clean some things up and also expose some handlebars helpers in the examples. Hopefully soon.

@hughstephens
Copy link

Hi guys, just checking in on this? Really keen for hbs support :)

@utsavkesharwani
Copy link

@niftylettuce: Was this done? Is handlebars supported? 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants