Upload images referenced in CSS files

[JoshuaGross]

I believe this was requested - though it's not through Stylus, LESS, etc. I decided it was easier to just parse out any images referenced in the CSS file. For me it was useless to CDNify CSS at all if it didn't also upload all images.

Note that this works with the background-image, background, and contents CSS attributes. The image paths MUST be absolute (e.g. if you do a "../whatever.png" it won't work) and a descendent of options.publicDir.

Let me know what you think!

[jmonster]

F YEAH :)

[niftylettuce]

cool let me check this out :)

[niftylettuce]

@JoshuaGross I think you need to swap imageResource with url?

[niftylettuce]

Rolled back

[JoshuaGross]

Not sure what you mean. Twitter bootstrap/all the CSS I've ever written looks like background: url(...)

-- Joshua Gross

On Sep 19, 2012, at 1:22 PM, Nick Baugh notifications@github.com wrote:

@JoshuaGross I think you need to swap imageResource with url?

—
Reply to this email directly or view it on GitHub.

[niftylettuce]

U defined imageResource car but didn't use it?
On Sep 19, 2012 2:57 PM, "Joshua Gross" notifications@github.com wrote:

Not sure what you mean. Twitter bootstrap/all the CSS I've ever written
looks like background: url(...)

-- Joshua Gross

On Sep 19, 2012, at 1:22 PM, Nick Baugh notifications@github.com wrote:

@JoshuaGross I think you need to swap imageResource with url?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/18#issuecomment-8702325.

[JoshuaGross]

Sorry, dumb response on my part. I assumed you were taking about CSS, not my JS code. I won't be able to look properly until tomorrow, do you have a fix that works?

-- Joshua Gross

On Sep 19, 2012, at 1:58 PM, Nick Baugh notifications@github.com wrote:

U defined imageResource car but didn't use it?
On Sep 19, 2012 2:57 PM, "Joshua Gross" notifications@github.com wrote:

Not sure what you mean. Twitter bootstrap/all the CSS I've ever written
looks like background: url(...)

-- Joshua Gross

On Sep 19, 2012, at 1:22 PM, Nick Baugh notifications@github.com wrote:

@JoshuaGross I think you need to swap imageResource with url?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/18#issuecomment-8702325.

—
Reply to this email directly or view it on GitHub.

[niftylettuce]

*var not car lol

[niftylettuce]

ok i see what you did with imageResource variable -- need to look into if you appended timestamp etc

[niftylettuce]

@JoshuaGross this works great man, awesome work. I published it in version 0.0.6 👍

[niftylettuce]

@jmonster you can use this in version 0.0.6

[niftylettuce]

@JoshuaGross one additional thing -- is that we should modify the CSS to support the appended timestamp format (e.g. background-image: url('/img/joshua.png') -> background-image: url('//abc123.cloudfront.net/img/joshua.123456789.png)`) -- do you think you can build that in too?

[niftylettuce]

edit: I updated previous comment from /img/joshua.png to /img/joshua.{{mtime}}.png

[JoshuaGross]

Awesome!

Wrt to including the timestamp - not actually sure how I would do that. The imageResource returned is undefined currently...