Added support for custom logger functions

[jameswyse]

Adds the ability to pass a custom logging function as an option.
The default is still console.log()

I use the excellent winston library to manage logs, so in this case I would pass my winston log function to express-cdn:

var options = {
  // other options
  logger: winston.info
}

var CDN = require('express-cdn')(express, options);
express.dynamicHelpers({ CDN: CDN });

[niftylettuce]

Great work with everything, ill look over today 👍
On Jul 5, 2012 4:06 AM, "James Wyse" <
reply@reply.github.com>
wrote:

Adds the ability to pass a custom logging function as an option.
The default is still console.log()

I use the excellent winston
library to manage logs, so in this case I would pass my winston log
function to express-cdn:

var options = {
  // other options
  logger: winston.info
}

var CDN = require('express-cdn')(express, options);
express.dynamicHelpers({ CDN: CDN });

You can merge this Pull Request by running:

git pull https://github.com/jameswyse/express-cdn custom-logger

Or you can view, comment on it, or merge it online at:

#6

-- Commit Summary --

• Added support for custom logger functions

-- File Changes --

M lib/main.js (9)

-- Patch Links --

https://github.com/niftylettuce/express-cdn/pull/6.patch
https://github.com/niftylettuce/express-cdn/pull/6.diff

---

Reply to this email directly or view it on GitHub:
#6

[emostar]

Using winston is definitely a good idea, I wouldn't be against making it be a requirement in fact...

[emostar]

Not to be nit picky... but I will anyway :P

if (options.logger) { would match the format used in the code.

[jameswyse]

hah, you're right. The shame!

Though really we should work on making the whole code more modular, i've another bug to solve involving timestamps in filenames and the code is a little confusing at present.

[niftylettuce]

I'll manually fix the format per @mathrawka suggestion \o

Excited to use loggly/winston together with this!