-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netbox_database_maintenance
variable
#158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, almost forgot. Please update the README.adoc
to include documentation for the new role variable and its usage.
I have added it ... somewhere, not quite sure where/how you'd want me to document it. |
There's a segment under Role Variables that goes over the other database connection parameters. That would be where. Ctrl+F "netbox_database" should get you to it, I think, if you're not sure where. Since this is one of those "edge case" parameters, it should probably get its own line, similar to the connection age variable, and an explanation of how it's used (e.g. ansible connects to it by default) and why one would change it. |
@MonsterDruide1 I think you might have forgot to force push the documentation update, so pinging you just in case. (Also see my last comment if you need it.) |
Sorry, took some time with other stuff - does this documentation match your request? |
Yeah, the documentation looks fine apart from the minor things I pointed out. |
Some use cases might not be able to access the default
postgres
database. To make sure that this playbook also works in these scenarios,maintenance_db
should be changed by using variables, passed from outside of the role.The default should still remain on
postgres
:https://docs.ansible.com/ansible/latest/collections/community/postgresql/postgresql_db_module.html