Create a new socket each time 'connect' is called

[akrabi]

Each call to connect will create a new socket (closing the old one) and use it to connect.
The purpose of this change is to allow recovery from a broken socket which is not possible without it (unless you create a new instance of the entire class).

Some additional changes:

• Add missing locking for all_on_off and toggle_mute operations
• Convert try/finally statements in favor of 'with' statements for locks
• Prefix local method with double underscore, this helps see which methods are part of the supported library API.
• Correct some spelling mistakes in logs and comments

[laf]

I don't use this anymore so I can't test it.

@acambitsis @altersis Any thoughts from either of you?

[akrabi]

Thanks for responding @laf .
As for testing, I've been using this modified version on my Home Assistant installation for several days and so far it looks good.
I am planning to follow-up on this PR with an update to the HA integration as well.

[acambitsis]

I'm also not using this anymore so I also can't test.

[altersis]

Hi Gents, happy new year! I'm still using this integration, and very happy that @akrabi had a chance to enhance it. I cannot test it today, but will certainly do it tomorrow and report back the results. Cheers!

[akrabi]

Hey @altersis , have you had a chance to test these changes?

[akrabi]

Hey, this change has been running on my HA installation for the past two weeks with no issues.
@acambitsis, do you still want to validate this on your setup?

[acambitsis]

@akrabi no need from my side. I have moved off russound a while back now. It was @altersis who has the ability to test, and can make a call if further testing is needed.

[akrabi]

@altersis ?