Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

INSTRUCTIONS: create users #56

Closed
ignasi35 opened this issue Mar 13, 2017 · 3 comments
Closed

INSTRUCTIONS: create users #56

ignasi35 opened this issue Mar 13, 2017 · 3 comments

Comments

@ignasi35
Copy link
Contributor

Add inline instructions to create several users

mehulsr added a commit to mehulsr/online-auction-java that referenced this issue Mar 16, 2017
jroper pushed a commit that referenced this issue Mar 17, 2017
* Issue #56: Added inline instruction for creating new user.

* Added inline instruction in messages file
@mehulsr
Copy link
Contributor

mehulsr commented Mar 20, 2017

Hi, my PR for this issue was merged. It is still open; does it need enhancement?

@TimMoore
Copy link
Contributor

@mehulsr this is done now. Thanks for pointing it out.

For future reference, GitHub has a convention where if you add "Fixes #56" (or whatever the issue number is) to the description of the pull request, it will close the issue automatically when the pull request is merged. So it's better to use this convention rather than putting the issue number in the title of the pull request, where GitHub doesn't look for it.

Here's GitHub's documentation on how this works: https://help.github.com/articles/closing-issues-via-commit-messages/

@mehulsr
Copy link
Contributor

mehulsr commented Mar 20, 2017

@TimMoore Okay, will keep this in mind for the next PR. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants