This repository has been archived by the owner on May 9, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
INSTRUCTIONS: create users #56
Labels
Comments
Closed
mehulsr
added a commit
to mehulsr/online-auction-java
that referenced
this issue
Mar 16, 2017
jroper
pushed a commit
that referenced
this issue
Mar 17, 2017
Hi, my PR for this issue was merged. It is still open; does it need enhancement? |
@mehulsr this is done now. Thanks for pointing it out. For future reference, GitHub has a convention where if you add "Fixes #56" (or whatever the issue number is) to the description of the pull request, it will close the issue automatically when the pull request is merged. So it's better to use this convention rather than putting the issue number in the title of the pull request, where GitHub doesn't look for it. Here's GitHub's documentation on how this works: https://help.github.com/articles/closing-issues-via-commit-messages/ |
@TimMoore Okay, will keep this in mind for the next PR. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add inline instructions to create several users
The text was updated successfully, but these errors were encountered: