-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
Hi there, thanks very much for the pull request. I'd love to acccept it, but first I'd like to consider the task name 'http' and the defaults (e.g. PUT and Basic-Auth). Unfortunately I'm about to leave for a holiday for a week, and I can't make/test a decision right now... I'll just leave you with some thoughts for the time being.
What do you think? |
We're publishing to an internal nexus deployment. Although it should work as is for many other compatible http or webdav servers such as alfresco, svn, apache, etc. +1 on Of course some other variations can be planned, specially in the authn side, but I believe using basic-auth is ok for a version 1 of the task, and is what I see most in other tools such as maven, sbt, etc. (Yes, I come from javaland). From a design standpoint, what I really don't like is exposing fileinfo and taskparams to the template producing an unwanted coupling... I thought of creating a map[string]string with relevant data for the task (but then: what is relevant data for the task?) and then use that as the context for the template expansion, but I wanted to discuss it a little first, given my little experience with golang & the goxc project (again, I find it ok as is for a first version). EDIT: fix wrong link to nexus site |
OK sweet. Nexus integration is a good thing.
Incidentally I just checked the github release api and it's going to be more similar to the bintray task (adding versions etc), so I'll do that separately. All good. OK, got to go. Cheers |
|
Thanks so much, sorry for not getting back sooner. The changes look good and I trust your workmanship. I just added you to the project. Would you like to merge it in yourself? It's a common policy for good pull-requests to be recognised in this way. Good work, my friend |
Thanks to you! I've had a pending small refinement in my local repo which explicits the default case for failing the publishing task if a file already exists in the remote http server (default behavior in other tools). Please check it out, and if the patch still looks good to you, then I'd be pleased to merge it. |
Travis CI build failure seems unrelated... so, I'm merging this anyway, since it works fine locally. |
This little patch adds an "http" task for publishing built artifacts using http PUT.
Tested/implemented for publishing to internal Nexus server used as internal artifact repository, but should be usable for any http server which accepts PUT requests (including any webdav server such as svn, alfresco or sharepoint) .
Allows to specify a template for building the url used for putting every file, as well as the http basic auth credentials to be used for the requests (should be set in
.goxc.local.json
).Exposes
FileInfo
andTaskParams
for use in the url template.Sample
.goxc.json
section:Sample
.goxc.local.json
section: