This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Simple attempt at fixing #91, in reaction to the ldflags behaviour-change in go1.5 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laher
added a commit
that referenced
this pull request
Mar 6, 2016
Simple attempt at fixing #91, in reaction to the ldflags behaviour-change in go1.5
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 21, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 21, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 21, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 23, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 23, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 23, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 23, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 23, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
vicamo
added a commit
to vicamo/aptly
that referenced
this pull request
Jan 23, 2022
goxc pull request aptly-dev#92[1] fixed a bug that version string passed by '-pv' would be wrapped with unexpected single quote chars. However, when it was cherry picked to stable release v0.18.1 in commit 60036dc[2], the rewritten patch doesn't really act the same and this issue remains unfixed. This fails a few test cases for checking aptly version string. This bumps required goxc revision to its current master branch HEAD. [1]: laher/goxc#92 [2]: laher/goxc@60036dc Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.