This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Made the github release upload URL dynamic #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2016 15:57
goxc was hardcoding the githup upload URL to point to github.com. This was breaking goxc release push on Github enterprise installation where the URL would be customdomain.com rather than github.com. This change reads the upload URL from the JSON message returned from Github API and uses that dynamically rather than hardcoding it.
|
Hi there. So sorry for neglecting this for so long. It looks awesome in principle, I just have one nit-pick - I'll comment on the relevant lines |
|
Actually no, I don't want to nit-pick. I was going to suggest more defensiveness around the split line, but on reflection it looks legit. Hang on, I'll add you to the project and then you can merge this pull request yourself. |
|
Thanks! |
anoopengineer
added a commit
that referenced
this pull request
Feb 29, 2016
Made the github release upload URL dynamic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goxc was hardcoding the githup upload URL to point to github.com.
This was breaking goxc release push on Github enterprise installation
where the URL would be customdomain.com rather than github.com.
This change reads the upload URL from the JSON message returned from
Github API and uses that dynamically rather than hardcoding it.