forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
FIX: Refactor computeMetaData and separate propagateNull() from compu…
…tePropagateNulls() API. (facebookincubator#5287) Summary: Pull Request resolved: facebookincubator#5287 This fix a set of expression fuzzer failures such as facebookincubator#5059. The diff split propagateNull() and computePropagateNulls() API. previously propagateNull() used to retrieve the propagateNull property for some expressions and re-compute it for others. with this change propagateNull() only accesses the pre-computed property. And computePropagateNulls() is called from computeMetaData to compute the property for some expressions. The diff also refactor computeMetaData for better readability, it used to interleave computations of different properties and combine things in a hard to track manner. Following diffs will address two remaining issues: - The re-compute that happens over and over during query compilations. - Avoid emptying distinct fields if shared with parents and simplify the API. Reviewed By: kagamiori Differential Revision: D46457021 fbshipit-source-id: 4fce60af50218405b83bd698f47645eb384aa5a6
- Loading branch information
1 parent
4c33afe
commit 23962d8
Showing
11 changed files
with
107 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters