starts of a GithubBackend #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencord0
reviewed
Nov 5, 2017
Cargo.toml
Outdated
| authors = ["Eirik Albrigtsen <ealbrigt@cisco.com>"] | ||
| description = "A strict, language-agnostic build system and dependency manager" | ||
| license = "MIT" | ||
| name = "lal" | ||
| version = "3.7.0" |
There was a problem hiding this comment.
ugh, it's just different tools keep re-ordering them. both clippy and cargo-edit change the key order in different ways. maybe one of them parses into a hashmap rather than a btreemap.
| #[derive(Serialize, Deserialize, Clone)] | ||
| pub struct GithubCredentials { | ||
| /// Personal access token with upload access | ||
| pub token: String, |
There was a problem hiding this comment.
Document how to get hold of one of these.
clux
force-pushed
the
github-backend
branch
2 times, most recently
from
62d16f7
to
2c5fe96
Compare
|
K. Legit failure. Finally travis. |
hubcaps is missing the release assets api unfortunately though. So we can create a release, but we can't attach our artifact to it yet. Stashing current work in a branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a new version of hubcaps that supports release assets before this can be used, but this contains the preliminary type setup. This would implement #1
Got stuck on having to add logic to hubcaps.
Think I had it almost working in lalbuild/hubcaps@a13f440