-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starts of a GithubBackend #9
base: master
Are you sure you want to change the base?
Conversation
Cargo.toml
Outdated
authors = ["Eirik Albrigtsen <ealbrigt@cisco.com>"] | ||
description = "A strict, language-agnostic build system and dependency manager" | ||
license = "MIT" | ||
name = "lal" | ||
version = "3.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetical keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, it's just different tools keep re-ordering them. both clippy and cargo-edit change the key order in different ways. maybe one of them parses into a hashmap rather than a btreemap.
#[derive(Serialize, Deserialize, Clone)] | ||
pub struct GithubCredentials { | ||
/// Personal access token with upload access | ||
pub token: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document how to get hold of one of these.
62d16f7
to
2c5fe96
Compare
K. Legit failure. Finally travis. |
hubcaps is missing the release assets api unfortunately though. So we can create a release, but we can't attach our artifact to it yet. Stashing current work in a branch.
Needs a new version of hubcaps that supports release assets before this can be used, but this contains the preliminary type setup. This would implement #1
Got stuck on having to add logic to hubcaps.
Think I had it almost working in lalbuild/hubcaps@a13f440