Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom tokenizers for the representations #21

Merged
merged 11 commits into from
Feb 14, 2024
Merged

feat: add custom tokenizers for the representations #21

merged 11 commits into from
Feb 14, 2024

Conversation

n0w0f
Copy link
Contributor

@n0w0f n0w0f commented Feb 13, 2024

robocrys tokenizer is pending, train bpe later after dataprep

setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly quite good to me!

src/xtal2txt/tokenizer.py Show resolved Hide resolved
src/xtal2txt/tokenizer.py Show resolved Hide resolved
src/xtal2txt/tokenizer.py Show resolved Hide resolved
src/xtal2txt/tokenizer.py Show resolved Hide resolved
src/xtal2txt/tokenizer.py Show resolved Hide resolved
src/xtal2txt/tokenizer.py Show resolved Hide resolved
src/xtal2txt/tokenizer.py Outdated Show resolved Hide resolved
src/xtal2txt/vocabs/cif_vocab.json Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly quite good to me!

@n0w0f n0w0f mentioned this pull request Feb 14, 2024
@n0w0f
Copy link
Contributor Author

n0w0f commented Feb 14, 2024

Thank you @kjappelbaum for the review

@kjappelbaum
Copy link
Contributor

looks all fine to me, happy to see this making progress 🦾

Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but please squash the commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants