Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some transition animation #320

Merged
merged 2 commits into from
Sep 25, 2023
Merged

update some transition animation #320

merged 2 commits into from
Sep 25, 2023

Conversation

lamarios
Copy link
Owner

change full progress indication on video list by a check mark instead of a full progress bar
sync view history from invidious on app start for logged in users
change time needed to send view status of a video to invidious from 90 to 10% fix #314

lamarios and others added 2 commits September 24, 2023 14:20
change full progress indication on video list by a check mark instead of a full progress bar
sync view history on app start for logged in users
change time needed to send view status of a video to invidious from 90 to 10% fix #314
@lamarios lamarios merged commit 8495112 into master Sep 25, 2023
@joseio
Copy link

joseio commented Sep 25, 2023

Awesome work, yet again! Out of sheer curiosity on my part, is there a particular reason (or set of reasons) that the debounced call to the Invidious History API was increased from five seconds to 10 minutes?

Seems like the increased time delay assumes that users are actively using the app for at least 10 minutes. Not saying that this assumption is reasonable or not; just pointing it out for discussion/understanding on my part. Thanks!

@lamarios
Copy link
Owner Author

lamarios commented Sep 25, 2023

I changed from a debounce to a throttle. Meaning that instead of waiting for it to have no calls for x minutes to trigger. It will trigger as soon as it can and prevent new triggers for x minutes.

It's easier to do this than keep track of whether I already sent the view status for this video.

@joseio
Copy link

joseio commented Sep 25, 2023

Ahhh, nice!!! Thanks for the transparency and great work!

@joseio
Copy link

joseio commented Oct 13, 2023

Hey @lamarios , sorry to revisit this, but do you see value in switching from a percentage to time in seconds, with regard to the threshold needed to add a video to a user's watch history?

I know this wouldn't affect a majority of users, but it would certainly help those who watch longer form videos (i.e., lectures or streams that go on for hours). For instance, a 2 hour stream implies that the user would need to be watching the video from the beginning for a contiguous 20 min. I suppose this is doable for most, but for longer videos, this may prove more challenging.

One workaround is simply scrubbing to a point well last the 10% mark (so that the video gets added to the watch history) and then scrubbing back to approximately where you left off. I don't expect many users to do this, however.

Anyhow, what are your thoughts on something like a 5-10 second threshold for adding a video to watch history, assuming the video is at least that long? Eager to hear your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Video to Watch History Before Reaching the 50% Mark
2 participants