Set default content-type html for actix feature #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me! Yeah, I think explicitly setting the encoding to UTF-8 makes sense. It's what Rocket does as well. |
|
Hello, is any update on the PR? Is there anything I can do to help? |
|
@Leward As noted above, we should set the encoding to UTF-8 as well. If you want to make a separate pull request with that change then I'll be happy to merge it. |
infogulch
force-pushed
the
actix-contenttype
branch
from
bf1f9f9
to
338d870
Compare
|
Hi! Sorry it took me so long to get to this. The code is now updated to include the encoding. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I used
@forof any kind in the returned Markup, Actix detected the content type asapplication/octet-stream, which prevented the browser from displaying it as html.This PR explicitly sets content-type to "text/html" in the Actix feature handler, and fixes the above issue. I don't see any reason why this would be incorrect, because all Markup instances are html. One adjustment might be to explicitly set encoding to utf-8. Let me know if you'd prefer that.