Improve error handling of ids variables #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
FailedToComputeOperands errorFailedToGetIds error
…pack_from_relocatable
fmoletta
changed the title
FailedToGetIds error
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
HermanObst,
juanbono and
Jrigada
as code owners
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
==========================================
+ Coverage 96.79% 96.82% +0.03%
==========================================
Files 69 69
Lines 28788 28835 +47
==========================================
+ Hits 27864 27920 +56
+ Misses 924 915 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Feb 17, 2023
Comment on lines
+23
to
+27
| pub(crate) struct BigInt3<'a> { | ||
| pub d0: Cow<'a, Felt>, | ||
| pub d1: Cow<'a, Felt>, | ||
| pub d2: Cow<'a, Felt>, | ||
| } |
There was a problem hiding this comment.
I wanted to use references when possible instead of cloning values, and using references wasn't possible
src/vm/errors/hint_errors.rs
Outdated
Comment on lines
15
to
18
| #[error("Expected ids.{0} to be an Integer value")] | ||
| IdentifierNotInteger(String), | ||
| #[error("Expected ids.{0} to be a Relocatable value")] | ||
| IdentifierNotRelocatable(String), |
There was a problem hiding this comment.
It may be a good idea (or not, I'm not really sure) to include the resolved address.
juanbono
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when retrieving ids values from memory, all internal memory errors get replaced by the
FailedToGetIdserror, which doesnt give us much information about what went wrong.This PR aims to remove this error, and replace it with variants that state which is the identifier that couldnt be computed.
Also, methods reflecting internal computation of ids values and addresses will have their return values changed to Option<>, as their errors arent and wont be used
This pr also refactors secp hints to use concrete types for structs (
EcPoint&BigInt3) failing to create these types will return anUnknownIdentifierorIdentifierHasNoMembererror instead of relying on internal memory errorsAfter this PR the following error cases will be outputed by the hint in case of undetermined ids:
UnknownIdentifier: The identifier is unknown (aka ids.val doesnt exist)IdentifierNotInteger/IdentifierNotRelocatable: The identifier is of invalid type (aka ids.val exists but its not integer/reloctable)IdentifierHasNoMember: The identifier doesnt have a member (aka ids.val.x doesnt exist or has incorrect type)