Migrate AddActivity to compose #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, adjust layout around it.
maxhille
approved these changes
Sep 19, 2022
app/src/main/java/com/lambdasoup/watchlater/ui/add/PlaylistSelection.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lambdasoup/watchlater/ui/add/AddScreen.kt
Outdated
Show resolved
Hide resolved
Current gotcha: ResultView switches its visibility itself. This does not get picked up by the parent Composable with regards to measurement. Not worth dealing with this right now; will revisit when migrating ResultView to compose.
(indeed makes the measurement problem from the previous commit disappear)
strooooke
force-pushed
the
feature/compose_add_activity
branch
from
f222949
to
19a05bf
Compare
Turns out that the setup in LauncherActivityTest does not need to be that complicated, using an EmptyComposeTestRule to interact with the compose nodes and an ActivityScenario to control the activity works just fine. No need to register the activity somehow with the ComposeTestRule. It just needs to exist as a Rule to set up the Compose component registry stuff. But since the plan is to get cucumber running again, I'm leaving the LauncherActivityTest as is.
strooooke
force-pushed
the
feature/compose_add_activity
branch
from
19a05bf
to
19109fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.