-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qa/psalm #13
Qa/psalm #13
Conversation
@boesing, if the PRs is correct, then you can put a label hacktoberfest-accepted on it? |
hey @superrosko, thanks for contributing! You need to apply these changes to all your pull requests. After this, I am happy to label your PRs and merge them! 💪🏻 You can verify your travis.yml here for compatibility. When everything is okay, you will see travis listed below the comment section in the "checks" area next to the DCO check 👍🏻 |
@boesing, thanks for pointing out the error, i fixed it for all my PRs |
psalm/plugin-phpunit min version 0.1.0 require vimeo/psalm version ^3.0, and vimeo/psalm ^3.0 require php ^7.0 only vimeo/psalm version 1.x can use php ^5.6||^7.0 and vimeo/psalm version 2.x can use php ^7.0 if we need support php 5.6 we must use vimeo/psalm 1.x and don't use psalm/plugin-phpunit anywhere |
@boesing, PR is correct? Or should all tests complete correctly? |
@superrosko We need another PR in here which solves #12 Thanks for implementing this! |
closes laminas-api-tools#11 Signed-off-by: Dmitriy Bespalov <dbespalov.rosko@gmail.com>
Description
Closes #11