Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa/psalm #13

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Qa/psalm #13

merged 1 commit into from
Jun 1, 2021

Conversation

superrosko
Copy link
Contributor

Q A
QA yes

Description

  • Create a psalm.xml in the project root
  • Copy and paste the contents from this psalm.xml.dist and fix projectFiles
  • Run $ composer --dev require vimeo/psalm
  • Run $ composer require --dev psalm/plugin-phpunit
  • Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
  • Add a composer script static-analysis with the command psalm --shepherd --stats
  • Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
  • Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Closes #11

@superrosko
Copy link
Contributor Author

@boesing, if the PRs is correct, then you can put a label hacktoberfest-accepted on it?

@boesing
Copy link
Member

boesing commented Oct 26, 2020

hey @superrosko, thanks for contributing!
sadly, travis is not executing anymore. That is because the travis.yml changes you've applied are not valid. Please re-check and see how to format the matrix entry.

You need to apply these changes to all your pull requests. After this, I am happy to label your PRs and merge them! 💪🏻

You can verify your travis.yml here for compatibility.

When everything is okay, you will see travis listed below the comment section in the "checks" area next to the DCO check 👍🏻

@superrosko
Copy link
Contributor Author

@boesing, thanks for pointing out the error, i fixed it for all my PRs

@superrosko
Copy link
Contributor Author

psalm/plugin-phpunit min version 0.1.0 require vimeo/psalm version ^3.0, and vimeo/psalm ^3.0 require php ^7.0

only vimeo/psalm version 1.x can use php ^5.6||^7.0 and vimeo/psalm version 2.x can use php ^7.0

if we need support php 5.6 we must use vimeo/psalm 1.x and don't use psalm/plugin-phpunit anywhere

@superrosko
Copy link
Contributor Author

@boesing, PR is correct? Or should all tests complete correctly?
To complete the tests, you need to remove the 5.6 and 7.0 posts.
Install the minimum version 7.1, because this is the minimum version for vimeo/psalm and psalm/plugin-phpunit?

@boesing
Copy link
Member

boesing commented Oct 31, 2020

@superrosko We need another PR in here which solves #12
After this, we can rebase this PR against that implementation and are good to go 👍

Thanks for implementing this!

@boesing boesing added Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 31, 2020
@boesing boesing added this to the 1.2.0 milestone Oct 31, 2020
closes laminas-api-tools#11

Signed-off-by: Dmitriy Bespalov <dbespalov.rosko@gmail.com>
@weierophinney weierophinney merged commit cd524f7 into laminas-api-tools:1.2.x Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psalm integration
3 participants