-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency bootstrap to v5 #121
Conversation
14cee99
to
14968be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A full change of bootstrap
will likely break everything :D
Worth checking /cc @michalbundyra @froschdesign
7e89422
to
03fbcd1
Compare
ec4acfd
to
b0e2578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No chance, a little more handwork is needed. Many breaking changes in version 5.
The migration is listed in the related project for the website: https://github.com/orgs/laminas/projects/23/views/2 |
| datasource | package | from | to | | ---------- | --------- | ----- | ----- | | npm | bootstrap | 4.6.2 | 5.2.2 | Signed-off-by: Renovate Bot <bot@renovateapp.com>
b0e2578
to
601ea7d
Compare
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^4.6.2
->^5.0.0
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Release Notes
twbs/bootstrap
v5.2.2
Compare Source
Highlights
.btn:hover
from v5.2.1. We now explicitly target.btn-check
styles instead.data
attribute (will be removed again in v6)<h1>
for all.modal-title
instances in our docs$border-color
intable-variant()
mixintab.show()
.active
class toggling of tabs within dropdownsz-index
on.toast-container
as opposed to individual.toast
s that don't receive any other positioningtitle
attribute on dynamically created elements🎨 CSS
.btn-check
and undo:hover
$border-color
intable-variant
mixin☕️ JavaScript
📖 Docs
<h1>
for allmodal-title
examples/usesview in GitHub
links insidemain
🌎 Accessibility
<h1>
for allmodal-title
examples/uses🏭 Tests
🧰 Misc
📦 Dependencies
v5.2.1
Compare Source
🚀 Highlights
color
value to use the$accordion-button-color
Sass variable instead of our color contrast functiontransparent
default hover border color CSS variable for buttons to fix a visual regression.btn-link
no longer has a gradient when$enable-gradients
is set totrue
z-index
values to ensure proper rendering of validated form fieldstext-align
to ensure consistent stylingborder-radius
list-group-item
selectors to better support nested imports of Bootstrap's CSSborder-radius
values inside pagination componentsselector
, dynamic content, and disposed tooltips usingtitle
🚀 Features
🎨 CSS
outline
for docs code samples, buttons when:not(:focus-visible)
$popover-header-color
.text-center
z-index
CSS variables..btn-link
☕️ JavaScript
📖 Docs
.form-checkbox
->.form-check
🛠 Examples
examples/features
page.🌎 Accessibility
outline
for docs code samples, buttons when:not(:focus-visible)
📦 Dependencies
v5.2.0
Compare Source
🚀 Highlights
smooth-scroll
behavior🚀 Features
smooth-scroll
behavior🎨 CSS
.form-control-color
sizing and styles.showing
btn-link
custom-property-empty-line-before
.table-group-divider
border.dropdown-item
border-radius
when$dropdown-padding-y
is0
readonly
inputs asdisabled
--bs-headings-color
CSS variable due to backward compatibility issuesdb61cf3
for$text-muted
default value.navbar-nav
--bs-btn-disabled-border-color
inbutton-outline-variant
mixin$display-font-family
and$display-font-style
☕️ JavaScript
smooth-scroll
behavior.show
from panels dependent-less on the existence of.fade
class📖 Docs
.is-invalid
from textarea validation exampleinterval=false
from docs & testsdata-bs-title
instead oftitle
type="button"
to Bootstrap versions dropdown🛠 Examples
🌎 Accessibility
type="button"
to Bootstrap versions dropdown🏭 Tests
spyOn
usage🧰 Misc
📦 Dependencies
v5.1.3
Compare Source
Fixes
🎨 CSS
align-self: center
to buttons for improved rendering in flex containers"v5.1.2
Compare Source
Highlights
calc()
functions that use negative numbers. This should restore the ability to import and compile Bootstrap's Sass increate-react-app
.border-radius
sizes to small and large.form-select
salign-self: center
to buttons for improved rendering in flex containerssms
in theSAFE_URL_PATTERN
.img-fluid
role="switch"
to our form switches in our docsChanges
🎨 CSS
align-self: center
to buttons for improved rendering in flex containersborder-radius
sizes to small and large.form-select
s☕️ JavaScript
sms
in theSAFE_URL_PATTERN
📖 Docs
role="switch"
to switches.img-fluid
in docscontents.md
🛠 Examples
role="switch"
to switches🧰 Misc
generatedCode: 'es2015'
📦 Dependencies
v5.1.1
Compare Source
Highlights
🎨 CSS
rgba-css-var
function for body or bg$dropdown-link-hover-color
variable color value in _variable.scss file☕️ JavaScript
bs-toggle
, to hide other open instancesdata-bs-original-title
issue📖 Docs
data-bs-original-title
issue$enable-smooth-scroll
to Sass options page.hstack
example and placeholder 'How it works' example.Site.Params.docs_version
variable🛠 Examples
🌎 Accessibility
🏭 Tests
📦 Dependencies
v5.1.0
Compare Source
Highlights
.bg-*
and.text-*
utilities to use CSS variables and new RGB CSS variables for real-time customization.col-*
classes to override.row-cols-*
classes for now until we can fix some critical bugs🚀 Features
data-dismiss
so that it can be outside of a modal usingbs-target
.hstack
,.vstack
, and.vr
getInstance
method🎨 CSS
.hstack
,.vstack
, and.vr
add()
andsubtract()
$card-box-shadow
variable$accordion-icon-color
default value consistent with the$accordion-button-color
.row-cols
"$input-bg
to use$body-bg
☕️ JavaScript
data-dismiss
so that it can be outside of a modal usingbs-target
Manipulator.offset()
display:none
by defaultswitch
statement instead ofif
getInstance
methodSelector.findOne()
dependencyUtil.reflow
function and add documentation📖 Docs
hr
in v5_root.scss
being requiredmedia-breakpoint-down
breakpoints🛠 Examples
.text-white-50
CSS rule from Offcanvas Example🌎 Accessibility
🔧 Utility API
🧰 Misc
aggregate-output
actions/setup-node
'scache
option📦 Dependencies
v5.0.2
Compare Source
🚀 Features
🎨 CSS
.row-cols
.form-select
add()
&subtract()
--bs-table-bg
and--bs-table-accent-bg
.dropdown-menu-*
line-height
for floating labels<ul><li>
/
division with multiplication and customdivide()
functiondivide()
function and RFS☕️ JavaScript
getOrCreateInstance
method in base-componentdispose
/hide
methods usage throughjQueryIntreface
getNextActiveElement
helper functiondata-dismiss="modal"
is setisVisible
false positives from deep nesting or alternate meanselement.parentNode.removeChild(element)
toelement.remove()
DOMContentLoaded
event listener inonDOMContentLoaded
📖 Docs
querySelectorAll
BlinkMacSystemFont
in docs<ul><li>
sass:math
module call🛠 Examples
setActiveItem()
🌎 Accessibility
🔧 Utility API
🏭 Tests
🧰 Misc
📦 Dependencies
v5.0.1
Compare Source
🎨 CSS
.modal-open
to affect the<body>
scroll.input-group
shouldn't be behind sibling elementaccent-bg
from leaking in nested table$list-group-color
in loop:read-only
selector back to[readonly]
☕️ JavaScript
config
property to start with underscoretransitionend
listener callbacks into one methodDATA_KEY
&EVENT_KEY
to base-componentrootElement
not initialized in Modal📖 Docs
🛠 Examples
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Read more information about the use of Renovate Bot within Laminas.