-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup capabilities #8
Comments
Perhaps While we're there, the format for
Maybe the last is a bug, or maybe I'm missing something. I can see some value in being able say "yes, the adapter will store it, but won't return the same type", but Originally posted by @kynx at zendframework/zend-cache#81 (comment) |
@kynx The idea behind this is as follows:
$value = 100;
$storage->setItem('key', $value);
var_dump($value == $storage->getItem('key')); // true
var_dump($value === $storage->getItem('key')); // true
$value = new stdClass;
$storage->setItem('key', $value);
var_dump($value == $storage->getItem('key')); // true
var_dump($value === $storage->getItem('key')); // false
In case for integer it should be Originally posted by @marc-mabe at zendframework/zend-cache#81 (comment) |
Hm, I will throw my two cents in here since I do use the cache component quite frequently in almost every project I am working on. I've never used the capabilities method and thus never had a need for this. Regarding the Do we have any thoughts on this? We (in our companies projects) do use ['lib_options' => [RedisCluster::OPT_SERIALIZER => RedisCluster::SERIALIZER_IGBINARY]]; It does in fact require the I guess the supported data types can be removed and instead require components to actually handle conversion/throw exceptions. TL;DR: I have never had the need to use the supported types since these are heavily depending on the serializer being used. The |
This also removes `capability` event and the `marker` object. Capabilities are meant to be read-only and thus won't change after retrieval via `StorageInterface#getCapabilties`. By having the event deleted, there is no need to have the adapter injected, though we also removed `Capabilities#getAdapter` and the `StorageInterface` constructor argument. By refactoring the `Serializer` plugin, which already replaced the initial instance of `Capabilities`, we were able to drop the `base capabilities` feature as well. Final result is that we now provide all capabilities as public `read-only` properties which reflect their defaults which were previously handled via internal `$default` magic in `Capabilties#getCapability`. Along all the refactoring, some capabilities have changed or were removed while respecting ideas of laminas#8 which was around since 2016: - `staticTtl` got removed without a replacement. It outlined if the cache backend is handling cache expiry or if the implementation is taking care of it. Though it might be interesting for picking a specific backend, that is rather not of interest at runtime for upstream projects. - `lockOnExpire` got removed without a replacement. Was only used in zend-server adapter which is already abandoned since 2022 - `minTtl` got renamed to `ttlSupported` and its type changed from `int` to `bool` - `maxTtl` got removed without a replacement. Every cache backend which is supported by laminas right now does allow TTLs being an infinite amount of seconds (where maximum `int` range is the limit, depending on the CPU architecture). There was a backend `XCache` where a limit existed but that backend was abandoned in 2021. - `useRequestTime` was renamed to `usesRequestTime` - `namespaceSeparator` got removed without a replacement. It was reflecting the option value and this the storage options can be used instead. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This also removes `capability` event and the `marker` object. Capabilities are meant to be read-only and thus won't change after retrieval via `StorageInterface#getCapabilties`. By having the event deleted, there is no need to have the adapter injected, though we also removed `Capabilities#getAdapter` and the `StorageInterface` constructor argument. By refactoring the `Serializer` plugin, which already replaced the initial instance of `Capabilities`, we were able to drop the `base capabilities` feature as well. Final result is that we now provide all capabilities as public `read-only` properties which reflect their defaults which were previously handled via internal `$default` magic in `Capabilties#getCapability`. Along all the refactoring, some capabilities have changed or were removed while respecting ideas of laminas#8 which was around since 2016: - `staticTtl` got removed without a replacement. It outlined if the cache backend is handling cache expiry or if the implementation is taking care of it. Though it might be interesting for picking a specific backend, that is rather not of interest at runtime for upstream projects. - `lockOnExpire` got removed without a replacement. Was only used in zend-server adapter which is already abandoned since 2022 - `minTtl` got renamed to `ttlSupported` and its type changed from `int` to `bool` - `maxTtl` got removed without a replacement. Every cache backend which is supported by laminas right now does allow TTLs being an infinite amount of seconds (where maximum `int` range is the limit, depending on the CPU architecture). There was a backend `XCache` where a limit existed but that backend was abandoned in 2021. - `useRequestTime` was renamed to `usesRequestTime` - `namespaceSeparator` got removed without a replacement. It was reflecting the option value and this the storage options can be used instead. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This also removes `capability` event and the `marker` object. Capabilities are meant to be read-only and thus won't change after retrieval via `StorageInterface#getCapabilties`. By having the event deleted, there is no need to have the adapter injected, though we also removed `Capabilities#getAdapter` and the `StorageInterface` constructor argument. By refactoring the `Serializer` plugin, which already replaced the initial instance of `Capabilities`, we were able to drop the `base capabilities` feature as well. Final result is that we now provide all capabilities as public `read-only` properties which reflect their defaults which were previously handled via internal `$default` magic in `Capabilties#getCapability`. Along all the refactoring, some capabilities have changed or were removed while respecting ideas of laminas#8 which was around since 2016: - `staticTtl` got removed without a replacement. It outlined if the cache backend is handling cache expiry or if the implementation is taking care of it. Though it might be interesting for picking a specific backend, that is rather not of interest at runtime for upstream projects. - `lockOnExpire` got removed without a replacement. Was only used in zend-server adapter which is already abandoned since 2022 - `minTtl` got renamed to `ttlSupported` and its type changed from `int` to `bool` - `maxTtl` got removed without a replacement. Every cache backend which is supported by laminas right now does allow TTLs being an infinite amount of seconds (where maximum `int` range is the limit, depending on the CPU architecture). There was a backend `XCache` where a limit existed but that backend was abandoned in 2021. - `useRequestTime` was renamed to `usesRequestTime` - `namespaceSeparator` got removed without a replacement. It was reflecting the option value and this the storage options can be used instead. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Some of the current defined capabilities are very hard to understand/useless and I would like to define some of them.
minTtl
This defines the minimum supported TTL which is clear but only a handful people knows that this also defines the general TTL support.
There is no adapter having another value than 0 or 1 so this can be renamed to
ttlSupported
withbool
.->
minTtl
needs to be still available for BC reasons until the next major but can be marked deprecated.staticTtl
This defines how the expiration time will be calculated which is not a meaningful description.
true
means the expiration time will be calculated on read using the last-modification-time of the item, the current time and the current TTL optionfalse
means the expiration time will be calculated using the current TTL and the current time. It will be stored together with the itemThoughts for better names ?
expiredRead
There was the idea that it is possible to read an expired item by setting changing the TTL (like to 0 = infinitive) but this only works with
staticTtl=true
to make it possible using an expired item in cases regeneration breaks (like on failed DB connection).This is a useless capability because changing the TTL to something else automatically changes the expiration time of all stored items if
staticTtl=true
which means in case for infinity the item is no longer expired. -> Bam the item is no longer expired but this capability is for reading expired items and the nature ofstaticTtl
already defines this behavior.-> I would like to deprecate this capability and remove it in the next major version.
@kynx @Maks3w @Ocramius @ezimuel Thoughts ?
Originally posted by @marc-mabe at zendframework/zend-cache#81
The text was updated successfully, but these errors were encountered: