Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ignore validation of ArgvInput #76

Merged
merged 1 commit into from
May 20, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented May 19, 2021

Q A
Bugfix yes

Description

Ignores the validation of ArgvInput while detecting the --container option.

Caveat

This will only work if the --container option is being passed before the commands name or right after the command name.

If the command has arguments, the --container option must be preceding the commands very first argument.

OK

$ laminas --container=<path> <command> [<argument>]
$ laminas <command> --container=<path> [<argument>]

NOK

$ laminas <command> <argument> --container=<path> 

fixes #74

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added the Bug Something isn't working label May 19, 2021
@boesing boesing added this to the 1.1.1 milestone May 19, 2021
@boesing boesing changed the base branch from 1.2.x to 1.1.x May 19, 2021 21:04
@boesing
Copy link
Member Author

boesing commented May 19, 2021

#75 would always detect the --container option, no matter where it is positioned. But it is indeed way more complex than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since upgrade to 1.1.0: Command works without parameter, but not with parameter anymore
2 participants