Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vimeo/psalm to 4.10 and add psalm/plugin-phpunit #80

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 17, 2021

Q A
QA yes

Description

This bumps psalm to its latest version while adding psalm/plugin-phpunit.

This also changes some Symfony\Component\Console\Question\Question#setValidator callables to static callables for minor speed improvements in newer PHP versions.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Copy link
Member Author

boesing commented Sep 17, 2021

ERROR: InvalidDocblock - src/Input/AbstractParamAwareInput.php:329:13 - Templated closures are not supported (see https://psalm.dev/008)
            /**
             * @psalm-template ValueType of mixed
             * @psalm-param callable(ValueType): bool $validator
             * @psalm-param ValueType $value
             */
            static function ($value) use ($originalValidator) {

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius self-assigned this Sep 17, 2021
@Ocramius Ocramius merged commit f2c68d5 into laminas:1.2.x Sep 17, 2021
@boesing boesing deleted the qa/bump-psalm branch September 17, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants