Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dynamic properties on the OCI8 adapters, to prevent PHP 8.2 deprecation warnings #282

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

parktrip
Copy link
Contributor

@parktrip parktrip commented Jan 23, 2023

As dynamic properties as not allowed anymore with 8.2, $parametersBound property was causing a deprecation notice "Creation of dynamic property Laminas\Db\Adapter\Driver\Oci8\Statement::$parametersBound is deprecated"

Signed-off-by: Olivier MELLINGER parktrip@gmail.com

Q A
Documentation no
Bugfix yes
BC Break yes
New Feature no
RFC no
QA no

Description

As dynamic properties as not allowed anymore with 8.2, $parametersBound property was causing a deprecation notice "Creation of dynamic property Laminas\Db\Adapter\Driver\Oci8\Statement::$parametersBound is deprecated"

Signed-off-by: Olivier MELLINGER <parktrip@gmail.com>
Signed-off-by: Olivier MELLINGER <parktrip@gmail.com>
src/Adapter/Driver/Oci8/Statement.php Outdated Show resolved Hide resolved
Signed-off-by: Olivier MELLINGER <parktrip@gmail.com>
Signed-off-by: Olivier MELLINGER <parktrip@gmail.com>
Signed-off-by: Olivier MELLINGER <parktrip@gmail.com>
Signed-off-by: Olivier MELLINGER <parktrip@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parktrip!

@Ocramius Ocramius self-assigned this Jan 31, 2023
@Ocramius Ocramius added this to the 2.17.0 milestone Jan 31, 2023
@Ocramius Ocramius changed the title Add $parametersBound property to the class to avoid deprecation notices Declare dynamic properties on the OCI8 adapters, to prevent PHP 8.2 deprecation warnings Jan 31, 2023
@Ocramius Ocramius merged commit 9020ba2 into laminas:2.17.x Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants