Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Renovate with reusable workflows #36

Merged
merged 15 commits into from
Mar 30, 2022
Merged

Prepare for Renovate with reusable workflows #36

merged 15 commits into from
Mar 30, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

@Ocramius Ocramius added this to the 1.14.0 milestone Feb 21, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rolling back to a much smaller composer.lock change (just hash change)

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests fail on silly thresholds due to integration scenarios running on the (very busy) workers

@Ocramius Ocramius self-assigned this Feb 23, 2022
@Ocramius
Copy link
Member

We should probably adjust this a bit to match (and replace)

name: "Execute Unit Tests"
?

We need services to be running in general, for this to work 🤔

@ghostwriter
Copy link
Contributor Author

@Ocramius Ocramius removed this from the 1.14.0 milestone Mar 2, 2022
@weierophinney
Copy link
Member

@ghostwriter I'm working on the conflict; need to resolve issues with the coding standard first (PR incoming...). I'll take it from here.

@Ocramius Ocramius added this to the 1.15.0 milestone Mar 30, 2022
@Ocramius Ocramius changed the base branch from 1.14.x to 1.15.x March 30, 2022 08:39
@Ocramius
Copy link
Member

Target branch was wrong here 🤔

weierophinney and others added 14 commits March 30, 2022 10:45
- Omitting declare(strict_types=1)
- Ignoring non-strict match when testing PHP flags

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
"New" errors introduced as all code was touched.

This primarily masks a lot of type mismatch, coercion, and invalid argument warnings in tests, and a few mixed assignment warnings in source code.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Needed to import several classes and functions

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
…tions

Since reusable workflows do not support services, we cannot re-use workflows here.
Instead of the old matrix type we had here, switching to the new one.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
With memcached extension installed, there were errors flagged; updated code, and then fixed baseline.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Remove (now) unnecessary import

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- bump enlightn/security-checker minimum version to 1.10
- Conflict with symfony/process, symfony/finder < 5.3.7

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@Ocramius
Copy link
Member

markdownlint failures unrelated, caused by current ongoing Russian invasion of Ukraine. This patch is ready to go, thanks @ghostwriter @weierophinney!

@Ocramius Ocramius merged commit 905e59c into laminas:1.15.x Mar 30, 2022
@Ocramius
Copy link
Member

Gonna release this one: lots of changes/improvements in 1.15.0, and it's best to have it tried out in the field too.

@ghostwriter ghostwriter deleted the feature/renovate branch March 30, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants