Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow php ~8.1.0 #17

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Allow php ~8.1.0 #17

merged 3 commits into from
Dec 13, 2021

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Dec 7, 2021

No description provided.

@fezfez
Copy link
Contributor Author

fezfez commented Dec 7, 2021

seem to work but need #16 before

@froschdesign froschdesign added this to the 2.9.0 milestone Dec 7, 2021
@fezfez
Copy link
Contributor Author

fezfez commented Dec 12, 2021

CI now working

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fezfez we need the composer.lock file to be re-generated here

@Ocramius Ocramius removed this from the 2.9.0 milestone Dec 12, 2021
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez
Copy link
Contributor Author

fezfez commented Dec 13, 2021

@Ocramius done

@Ocramius Ocramius self-assigned this Dec 13, 2021
@Ocramius Ocramius modified the milestones: 2.7.3, 2.10.0 Dec 13, 2021
@Ocramius Ocramius merged commit 30f37a2 into laminas:2.9.x Dec 13, 2021
@Ocramius
Copy link
Member

Thanks @fezfez!

@fezfez
Copy link
Contributor Author

fezfez commented Dec 13, 2021

hi @Ocramius the 2.10.0 version seem to not have the modification in it... :s

@fezfez
Copy link
Contributor Author

fezfez commented Dec 13, 2021

it appear to be merge in 2.9.x

@Ocramius
Copy link
Member

My bad, fixing shortly

@fezfez
Copy link
Contributor Author

fezfez commented Dec 13, 2021

same problem on laminas-navigation :s laminas/laminas-navigation#28

@Ocramius Ocramius modified the milestones: 2.10.0, 2.11.0 Dec 13, 2021
@Ocramius
Copy link
Member

Now fixed: 2.10.0...2.11.0

Sorry for the noise :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants