Fixes 32 - Method getDateModified of RSS reader doesn't iterate over different formats

[froschdesign]

Q	A
Bugfix	yes

[weierophinney]

Changes look reasonable to me. Please check the Psalm output, though, as you'll either need to correct some new issues, or add to the baseline:

• https://travis-ci.com/github/laminas/laminas-feed/jobs/464005564#L793

[froschdesign]

@weierophinney

Please check the Psalm output, though, as you'll either need to correct some new issues…

Yes, there are massive problems with many bugs. But these are old problems and not related to this pull request. No new problems are introduced with this PR.

---

Pslam reports the following problem for example:

RedundantCastGivenDocblockType - test/Reader/Entry/AtomStandaloneEntryTest.php:150:39

Redundant cast to array given docblock-provided type (see https://psalm.dev/263)
$this->assertEquals($authors, (array) $entry->getAuthors());

https://travis-ci.com/github/laminas/laminas-feed/jobs/464005564#L881-L882

But the problem is not the redundant cast, the problem is the related DocBlock:

laminas-feed/src/Reader/Feed/FeedInterface.php

Lines 26 to 31 in db2d647

	/**
	* Get an array with feed authors
	*
	* @return array
	*/
	public function getAuthors();

It's not a array it's a collection or null:

laminas-feed/src/Reader/Collection/Author.php

Lines 11 to 27 in db2d647

	class Author extends AbstractCollection
	{
	/**
	* Return a simple array of the most relevant slice of
	* the author values, i.e. all author names.
	*
	* @return array
	*/
	public function getValues()
	{
	$authors = [];
	foreach ($this->getIterator() as $element) {
	$authors[] = $element['name'];
	}
	return array_unique($authors);
	}
	}

laminas-feed/src/Reader/Feed/Rss.php

Lines 124 to 126 in db2d647

	if (count($authors) === 0) {
	$authors = null;
	}

[froschdesign]

There is a separate issue report for the wrong DocBlocks: #30