-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed StrategyInterface::hydrate() docblock because it is not optional #23
Conversation
svycka
commented
Aug 19, 2020
Q | A |
---|---|
Documentation | yes |
A bigger problem is included in the documentation: https://docs.laminas.dev/laminas-hydrator/v3/strategy/#introduction |
whops wrong branch bet I see documentation issue so will leave as it is as I don't know how you will address this good luck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for making the change, @svycka. One final step required, https://github.com/laminas/laminas-hydrator/pull/23/checks?check_run_id=1003015316.
@settermjd I have fixed it. But I think this is not a docblock bug but interface should allow optional context. I think @weierophinney introduced this unintentionally when added typehints. Also as @froschdesign noted documentation has it correctly https://docs.laminas.dev/laminas-hydrator/v3/strategy/#introduction but changing interface now I am not sure it's BC break or not? @weierophinney what do you think? |
The title of this pull request is to the update the DocBlock and this must be done in the related PHP file and documentation file. Everything else needs a new issue report or a discussion in the forum. |
Signed-off-by: Vytautas Stankus <svycka@gmail.com>