Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Psalm integration #33

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Adds Psalm integration #33

merged 1 commit into from
Oct 6, 2020

Conversation

weierophinney
Copy link
Member

Adds Psalm integration into the QA workflow.

Variations from the recommendation in #28:

  • Configuration file is psalm.xml.dist, not .psalm.xml.dist.
  • Does NOT use phpunit plugin in configuration (caused Psalm to raise an exception, even when I had it installed).
  • Does NOT scan bin directory (this repo does not have one).
  • Removes previous phpstan integration (this was part of the brief, but I thought I'd call it out).

Fixes #28

@weierophinney
qa: adds psalm integration
11173ae 
- Does NOT use phpunit plugin
- Does NOT scan bin directory (this repo does not have one)
- Removes previous phpstan integration

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney added this to the 3.2.0 milestone Oct 6, 2020
@weierophinney weierophinney merged commit 11173ae into laminas:3.2.x Oct 6, 2020
@github-actions github-actions bot mentioned this pull request Oct 6, 2020
Merged
@weierophinney weierophinney deleted the feature/psalm-integration branch October 6, 2020 19:51
@README1ST README1ST mentioned this pull request Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
1 participant
@weierophinney