Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 support added #57

Merged
merged 4 commits into from
Nov 8, 2023
Merged

PHP 8.3 support added #57

merged 4 commits into from
Nov 8, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@froschdesign
Copy link
Member

@glo71317
The validation of the PHPUnit configuration (phpunit.xml.dist) fails: https://github.com/laminas/laminas-paginator/actions/runs/6493438436/job/17634391697?pr=57#step:3:311

@froschdesign froschdesign added this to the 2.18.0 milestone Oct 18, 2023
@glo05363
Copy link
Contributor

glo05363 commented Nov 3, 2023

@gsteel would you please check here

laminas-paginator/psalm-baseline.xml

Line 222 in 4b2f26b

<file src="src/ScrollingStylePluginManager.php">
I have baselined the particular failing check https://github.com/laminas/laminas-paginator/actions/runs/6742756417/job/18329425939?pr=57 , somehow it is not passing, please give me a suggestion here.

@glo71317
Copy link
Contributor Author

glo71317 commented Nov 7, 2023

@gsteel PR is green now Can you please review the PR and merge?

@Ocramius Ocramius self-assigned this Nov 8, 2023
Ocramius
Ocramius approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glo71317!

@Ocramius Ocramius merged commit caacfd2 into laminas:2.18.x Nov 8, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
PHP 8.3
Status: Done
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@glo71317 @froschdesign @glo05363 @Ocramius