Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove laminas-console dependency #126

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 31, 2022

Q A
BC Break yes

Description

Closes #115
WRT #101

  • Removes Console Model and Renderer
  • Removes laminas-console from dev dependencies

@gsteel gsteel marked this pull request as draft January 31, 2022 20:57
@gsteel
Copy link
Member Author

gsteel commented Jan 31, 2022

For some reason, this pull has re-triggered a metric tonne of existing psalm errors. Probably gonna need to attend to those separately as none of them are related to this pull

@gsteel
Copy link
Member Author

gsteel commented Feb 1, 2022

This is now effectively blocked until 2.20 is released and merged up

- Removes Console Model and Renderer
- Removes laminas-console from dev dependencies

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel marked this pull request as ready for review March 23, 2022 14:42
@Ocramius Ocramius added this to the 3.0.0 milestone Mar 23, 2022
@Ocramius Ocramius merged commit dceb7b6 into laminas:3.0.x Mar 23, 2022
@Ocramius
Copy link
Member

Thanks @gsteel!

@Ocramius Ocramius self-assigned this Mar 23, 2022
@gsteel gsteel deleted the remove-console branch March 23, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove console related code
2 participants