-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate jsonExpressionFinder
usage in Json
view helper
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsteel
changed the title
Triggers a deprecation error when JsonExpressionFinder option is used.
Deprecate JsonExpressionFinder usage in Json View Helper
Dec 17, 2021
gsteel
force-pushed
the
deprecate-json-expr-finder
branch
from
December 17, 2021 15:29
c5ea082
to
1f94a12
Compare
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Co-authored-by: Frank Brückner <info@froschdesignstudio.de> Signed-off-by: George Steel <george@net-glue.co.uk>
Co-authored-by: Frank Brückner <info@froschdesignstudio.de> Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
deprecate-json-expr-finder
branch
from
December 20, 2021 12:06
c5b811d
to
9a4975a
Compare
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Dec 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of E_USER_DEPRECATED
, but in this case, it is true that we can't do it in a different way, due to the deprecation being bound to a specific value combination, rather than a specific type.
Ocramius
changed the title
Deprecate JsonExpressionFinder usage in Json View Helper
Deprecate Dec 30, 2021
jsonExpressionFinder
usage in Json
view helper
Thanks @gsteel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per discussion about removing the dependency on
laminas-json
in #68 - This adds a deprecation warning when the relevant option is detected paving the way for removal in 3.0